Add support for single file hubs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
reviewed
Apr 3, 2023
|
it's just a dev dep, and it's easier than writing an if statement or our
own assert function. what's the big deal?
…On Mon, Apr 3, 2023 at 11:29 AM Colin Diesh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/raStanza.test.ts
<#34 (comment)>:
> @@ -179,6 +179,7 @@ describe('RaStanza reader', () => {
const input = 'key1 value1\nkey2 value2\nkey3\n'
const stanza = new RaStanza(input)
let updatedValue = stanza.get('key2')
+ assert(updatedValue)
can we avoid using the 'assert' library?
—
Reply to this email directly, view it on GitHub
<#34 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASAFNPNNXXFX25NJERZPDW7MJHBANCNFSM6AAAAAAWRVVL2M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
we don't use |
|
the assert is there pretty much just for TS. jest expect isn't understood
by typescript to stop execution of the function like assert is, for
whatever reason.
I removed the dev dep on assert, is that ok?
…On Mon, Apr 3, 2023 at 11:42 AM Colin Diesh ***@***.***> wrote:
we don't use assert in any of our other libraries currently as far as I
know, so it's a little out of place to me, and it seems like it can instead
use a jest 'expect' type statement instead? it is also a node built-in, but
it is being installed as an npm module
https://www.npmjs.com/package/assert
—
Reply to this email directly, view it on GitHub
<#34 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASAFPRAASITQDURTPVTVDW7MKYFANCNFSM6AAAAAAWRVVL2M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
if you can add a comment saying why it is there (e.g. the typescript thing) it may help future readers, but otherwise it is fine |
Closed
cmdcolin
force-pushed
the
single-file-hub
branch
from
0e81296
to
fe0a131
Compare
cmdcolin
changed the title
|
let's get this one going :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.